Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] Add node-test-commit-test #1329

Closed
wants to merge 2 commits into from
Closed

[WIP] Add node-test-commit-test #1329

wants to merge 2 commits into from

Conversation

maclover7
Copy link
Contributor

@maclover7 maclover7 commented Jun 10, 2018 •
edited by refack
Loading

Starting point for having all node-test-commit sub jobs use a single script. Will be helpful when/if we move to pipelines, since all will be in one place

  • freebsd
  • linux
  • osx
  • plinux
  • smartos
  • windows
  • linux-containered
  • linux-containered --> ubuntu1604_sharedlibs_debug_x64
  • arm
  • arm-fanned
  • linuxone
  • aix

@refack
Copy link
Contributor

refack commented Jun 10, 2018

Great idea. We also have the regular job DSL plugin (and there the XML to DSL tool in the main screen).
BTW it's now quite possible to script the windows jobs in bash.

richardlau

This comment was marked as off-topic.

Sign in to view

@mhdawson
Copy link
Member

I'm +1 assuming we test across all of the platforms.

@maclover7 maclover7 force-pushed the jm-node-test branch 2 times, most recently from 447a175 to 462e197 Compare June 11, 2018 20:07
@maclover7
jenkins: add node-test-commit-test script
4dfa62d 
Centralized script for all node-test-commit subjobs in ci-public.
@refack
Copy link
Contributor

refack commented Jun 14, 2018

A few comments:

  1. The script needs to be run with bash -xe
  2. IMHO this should be a new sub-job and platform labels added to is as other subjobs are retired. (I'm starting this now)
    1. This will get us a simpler outcome
    2. This allows for only a single point where the branch URI is used
    3. It's easier to switch back in case of bug
  3. Testing needs to be done with 3 positive controls
    1. Known green
    2. Known red
    3. known yellow

@maclover7
Copy link
Contributor Author

Going to close this for now, and roll out in smaller increments

@maclover7 maclover7 closed this Jun 14, 2018
@maclover7 maclover7 deleted the jm-node-test branch June 14, 2018 20:04
@refack
Copy link
Contributor

refack commented Jun 14, 2018

You deleted the branch 😢 so now
https://raw.githubusercontent.com/maclover7/build/jm-node-test/jenkins/scripts/node-test-commit-test.sh is 404

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@richardlau richardlau richardlau left review comments

Assignees
No one assigned
Labels
ci-public
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@maclover7 @refack @mhdawson @richardlau